Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved main_nav to components #1409

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Conversation

heyitsmebev
Copy link

Description

Part of the larger ticket around converting navigations to components #1350

@heyitsmebev heyitsmebev linked an issue Apr 9, 2024 that may be closed by this pull request
Copy link
Contributor

@jonathanbobel jonathanbobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @heyitsmebev!

@ccostino
Copy link
Contributor

D'oh, small merge conflict with the previous PR that got merged.

@ccostino ccostino merged commit d464dd2 into main Apr 11, 2024
8 checks passed
@ccostino ccostino deleted the 1353-convert-main_navhtml-to-component branch April 11, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

convert main_nav.html to component
3 participants