Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix service stats #1411

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix service stats #1411

merged 1 commit into from
Apr 10, 2024

Conversation

terrazoon
Copy link
Contributor

@terrazoon terrazoon commented Apr 10, 2024

Description

The back end used to send service stats with one of the keys being 'failed'. Somehow that has changed to 'failure', resulting in the KeyError. It also results in a couple links on the platform admin tab being broken ('Live Services', 'Trial Services').

Fix the front end so it can accept either 'failure' or 'failed'.

Security Considerations

N/A

Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @terrazoon!

@ccostino ccostino merged commit 004343a into main Apr 10, 2024
8 checks passed
@ccostino ccostino deleted the notify-admin-1323 branch April 10, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: KeyError being thrown in app/main/views/platform_admin.py - create_global_stats method
2 participants