add e2e variables to manifest #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccostino
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Thanks, @terrazoon! 🤦 of course... too many steps involved with these!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have already created an E2E test user on staging. However this user's credentials are not available on staging as environment variables, which means that when we try to run E2E tests that point to the staging API server, they fail because they cannot login as the E2E test user.
Add these environment variables to the manifest and deploy to staging, so they appear as environment variables in staging, then follow up with the actual E2E PR that tests against the staging API server.
Security Considerations
N/A