Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2e test invite to service #1435

Merged
merged 13 commits into from
Apr 19, 2024
Merged

E2e test invite to service #1435

merged 13 commits into from
Apr 19, 2024

Conversation

A-Shumway42
Copy link
Member

@A-Shumway42 A-Shumway42 commented Apr 17, 2024

Description

e2e-test for inviting a team member to a service.

There is an issue with checking the "Send messages" checkbox. It is possible that the text isn't unique for the permission since there is also a "Send messages" button on the left nav.

Security Considerations

None

@A-Shumway42 A-Shumway42 marked this pull request as ready for review April 18, 2024 16:35
@A-Shumway42 A-Shumway42 linked an issue Apr 18, 2024 that may be closed by this pull request
3 tasks
@xlorepdarkhelm
Copy link
Contributor

I see testing errors, but not in your code. LGTM once the testing errors are squashed.

Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @A-Shumway42! 🎉

And nearly all the way there, except for the email sending part! We'll get that last bit in once we have these working against the staging API. 🙂

@ccostino ccostino merged commit 8e7cc19 into main Apr 19, 2024
8 checks passed
@ccostino ccostino deleted the e2e-test-invite-to-service branch April 19, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add end-to-end test: Invite a team member
4 participants