try to fix authentication issue by removing 'dead' code in signin #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removing dead code is a great idea! However, there's a bit more work to be done with this and we determined it'll be better to approach this slower and start over, since this was made quickly in an attempt to address the prod issue we had. We're closing this PR and open a new issue for this work. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are running into an authentication issue when people try to sign in and don't really understand why. Yesterday, we removed the UI portion of the LoginForm (which allowed users to login with a username and password). However, there was still code in place to support that form and that code was getting hit. So, remove this dead code in the hopes that it has something to do with the authentication issue. Verified that we can log in successfully with login.gov after this removal (but we could log in successfully before as well).
Security Considerations
N/A