Removed canceled users from displaying in dashboard #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anagradova
requested review from
ccostino and
heyitsmebev
and removed request for
ccostino and
heyitsmebev
ccostino
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Thanks, @anagradova!
In the future we may want to consider doing the filtering out of the invite status in the view code itself so when we're retrieving the records from the database, we're only grabbing the records that we need from the source. This way we're not returning a larger set of data than we need and adding extra excluding/filtering logic in the UI.
However, not a concern for now! We're dealing with a small set of records for these things, and this page will be revisited in the future for larger-scale changes. 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A note to PR reviewers: it may be helpful to review our
code review documentation
to know what to keep in mind while reviewing pull requests.
Description
Adjusted the manage-users.html template to not display users with a canceled invite. Also, added the option to cancel a user in addition to resending the invite.
This should include:
This addressed the request in #1155
TODO (optional)
Security Considerations
NA