Skip to content

Commit

Permalink
Bump utils to version 56.0.0
Browse files Browse the repository at this point in the history
The only impactful change is the major version itself, where I've
fixed the breaking changes due to the upgrade of PyPDF2 [^1] and
checked there are no deprecation warnings when I run the tests.

[^1]: alphagov/notifications-utils#973
  • Loading branch information
Ben Thorner committed Jun 1, 2022
1 parent 6495b19 commit ee8e86f
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion app/template/rest.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
BroadcastMessageTemplate,
SMSMessageTemplate,
)
from PyPDF2.utils import PdfReadError
from PyPDF2.errors import PdfReadError
from requests import post as requests_post
from sqlalchemy.orm.exc import NoResultFound

Expand Down
2 changes: 1 addition & 1 deletion requirements.in
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ notifications-python-client==6.3.0
# PaaS
awscli-cwlogs==1.4.6

notifications-utils @ git+https://github.com/alphagov/notifications-utils.git@55.1.6
notifications-utils @ git+https://github.com/alphagov/notifications-utils.git@56.0.0

# gds-metrics requires prometheseus 0.2.0, override that requirement as 0.7.1 brings significant performance gains
prometheus-client==0.14.1
Expand Down
6 changes: 4 additions & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ mistune==0.8.4
# via notifications-utils
notifications-python-client==6.3.0
# via -r requirements.in
notifications-utils @ git+https://github.com/alphagov/notifications-utils.git@55.1.6
notifications-utils @ git+https://github.com/alphagov/notifications-utils.git@56.0.0
# via -r requirements.in
orderedset==2.0.3
# via notifications-utils
Expand Down Expand Up @@ -189,7 +189,7 @@ pyjwt==2.4.0
# notifications-python-client
pyparsing==3.0.9
# via packaging
pypdf2==1.28.2
pypdf2==2.0.0
# via notifications-utils
pyproj==3.3.1
# via notifications-utils
Expand Down Expand Up @@ -250,6 +250,8 @@ sqlalchemy==1.4.36
# marshmallow-sqlalchemy
statsd==3.3.0
# via notifications-utils
typing-extensions==4.2.0
# via pypdf2
uri-template==1.2.0
# via jsonschema
urllib3==1.26.9
Expand Down
2 changes: 1 addition & 1 deletion tests/app/template/test_rest.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import requests_mock
from freezegun import freeze_time
from notifications_utils import SMS_CHAR_COUNT_LIMIT
from PyPDF2.utils import PdfReadError
from PyPDF2.errors import PdfReadError

from app.dao.templates_dao import (
dao_get_template_by_id,
Expand Down

0 comments on commit ee8e86f

Please sign in to comment.