make sure original_file_name is stored as part of job (notify-admin-1… #822
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@terrazoon is there an issue that this PR could be linked to? Also, it looks ready to go, so we can ask for peer review on it as well. Thanks! |
It can't be linked because the original ticket was written against the admin project. I've listed the number in the title of this PR. |
A-Shumway42
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the user is sending one-off messages, there is a case where the 'original_file_name' is not displayed in the UI as it should be. This seems to occur the first time you create a template. And the root cause is that the schema loading for the job doesn't populate the 'original_file_name' field.
Security Considerations
N/A