Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simulated sms numbers to allow list in trial mode. #855

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

A-Shumway42
Copy link
Member

Description

We recently had a discussion to allow devs to send to the simulated sms numbers while in trial mode. These changes are also further necessary for Cloudwatch alerts testing in staging.

TODO (optional)

  • Check in paired PR in admin at the same time.

Security Considerations

None. We are using simulated numbers through AWS.

@A-Shumway42 A-Shumway42 linked an issue Mar 14, 2024 that may be closed by this pull request
Copy link
Contributor

@terrazoon terrazoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @A-Shumway42 and @terrazoon!

@ccostino ccostino merged commit 8470c25 into main Mar 14, 2024
5 checks passed
@ccostino ccostino deleted the add-simulated-to-local branch March 14, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow simulated sms numbers to be used in trial mode
3 participants