Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login.gov first time workflow notify-api-1250 #865

Merged
merged 7 commits into from
Mar 26, 2024
Merged

Conversation

terrazoon
Copy link
Contributor

@terrazoon terrazoon commented Mar 19, 2024

Description

The new "Set Up Your Profile" workflow for first time users involves them being redirected to the login.gov website after they click "Join Service" in the invitation email.

TODO (optional)

  • Don't merge this until the matching 1250 PR in admin is merged.
  • Eventually the "password" column should go away in the users table. For right now, new users will be getting a UUID automatically for their password (once login.gov is mandatory, they will never have a need for one)

Security Considerations

N/A

Copy link
Member

@A-Shumway42 A-Shumway42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I just have questions about passwords/login. Will dev work flow through the login.gov sign in? If not, would we still need the password column for devs?

@terrazoon
Copy link
Contributor Author

Looks good to me. I just have questions about passwords/login. Will dev work flow through the login.gov sign in? If not, would we still need the password column for devs?

Dev flow is going to have to change. We will have to run the "create test user" command in order to create the first user in a clean setup. After that, we will have to log in with login.gov whether we use the sign in page, or respond to an invite.

Copy link
Contributor

@xlorepdarkhelm xlorepdarkhelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM.

@terrazoon terrazoon marked this pull request as draft March 21, 2024 18:22
@terrazoon terrazoon marked this pull request as ready for review March 22, 2024 19:40
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @terrazoon!

@ccostino ccostino merged commit f3136a7 into main Mar 26, 2024
5 checks passed
@ccostino ccostino deleted the notify-api-1250 branch March 26, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants