Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move createdb step #888

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Move createdb step #888

merged 1 commit into from
Apr 3, 2024

Conversation

jskinne3
Copy link
Contributor

@jskinne3 jskinne3 commented Apr 2, 2024

The command createdb test_notification_api is a prereq to running make test. Clarify that it is necessary, not just a troubleshooting step.

The command `createdb test_notification_api` is a prereq to running `make test`. Clarify that it is not just a troubleshooting step.
@jskinne3 jskinne3 requested review from ccostino, heyitsmebev and a team April 2, 2024 15:58
Copy link
Contributor

@xlorepdarkhelm xlorepdarkhelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jskinne3!

@ccostino ccostino merged commit 965d88b into main Apr 3, 2024
5 checks passed
@ccostino ccostino deleted the jskinne3-createdb-prereq branch April 3, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants