Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make email_address check case insensitive #934

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Conversation

terrazoon
Copy link
Contributor

@terrazoon terrazoon commented Apr 18, 2024

Description

The db check between what we had stored in the users table and what was coming from login.gov was case sensitive, and people seem to write their emails differently for different apps.

Security Considerations

N/A

@terrazoon terrazoon requested review from ccostino and a team April 18, 2024 20:34
@terrazoon terrazoon self-assigned this Apr 18, 2024
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @terrazoon!

One small quick change with removing the debug statement. :-)

app/dao/users_dao.py Outdated Show resolved Hide resolved
@ccostino ccostino merged commit 8414fd2 into main Apr 18, 2024
5 checks passed
@ccostino ccostino deleted the check-db-notification-fails branch April 18, 2024 20:45
Copy link
Contributor

@jskinne3 jskinne3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants