Remove dependency on rxjs-compat #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@diego-ruiz-rei, @thomastighe, @davereed Please have a look at. Even though I removed the rxjs-compat dependcy, ngx-formly still needs it, but I can't yet removed it from sam-front-end. But, I think this is still worth committing for when ngx-formly remove rxjs-compat. |
yerramshilpa
approved these changes
Dec 13, 2019
yerramshilpa
added a commit
that referenced
this pull request
Feb 12, 2020
* packages json added * sam-ui changes * reference change * document fixes * updated cdk to 8.2.1 * tabs fixes * sidenav cdk issues * table fixes * cdk table reference changes * export module changes * view child static value changes to true * specs changes * skipped test cases and updated test app package json * master conflict changes * cdk reference changes * skiped test * Document object fixes * package updates * conflict changes * chaged sam version * viewchild fixes * viewchild update * viewchild fix * viewchild fix * remove dependency on rxjs-compat (#473) * Test cases fixed * cleanup (#467) * removed an extra of import * Package version updated * fixes (#478) * Making static as false for resultList to remove console error (#479) * beta version updated * fix: show aria-expanded only when it has children * fix: render sam-menu-item only when it has children * feat: add aria-current when the link its selected * updating beta vesrion to 3 * Removed '_' and name changes (#485) * IAE-29041 required label changes (#486) * required text updated for Screen reader. * requred lable changes * Autocomplete WAI-ARIA 1.2 changes (#487) * WAI-ARIA 1.2 release changes for auto complete * experimental hierarchy-autocomplete changes * IAE-29063 Updated aria label for remove item. (#488) * Updated aria label for remove item. * removed extra text * updated package version Co-authored-by: Thomas Tighe <38287283+thomastighe@users.noreply.github.com> Co-authored-by: Justin Babbs <justin.babbs@gmail.com> Co-authored-by: Diego Ruiz <diego.ruiz@reisystems.com> Co-authored-by: nanacharyareisystems <narayan.acharya@reisystems.com> Co-authored-by: Carlos Valle <carlos.m.valle@gmail.com> Co-authored-by: davereed <dave@contagious.ly>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to remove the dependency on rxjs-compat. This compiles in sam-front-end.