Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-531-autocomplete-amp-issues #538

Open
wants to merge 1 commit into
base: angular-10
Choose a base branch
from

Conversation

Bibek-Regmi
Copy link
Contributor

Description

Resolves amp violations for autocomplete described in git #531
AMP issue with assigning combobox role to an element with no aria label
AMP issue with non-unique ID for sam-actions-dropdown

Motivation and Context

Type of Change (Select One and Apply Github Label)

  • Bug fix (non-breaking change which fixes an issue) -> Apply bugfix label
  • New feature (non-breaking change which adds functionality) -> Apply enhancement label
  • Breaking change (fix or feature that would cause existing functionality to change) -> Apply breaking label

Screenshots (if appropriate):

Which browsers have you tested?

  • Internet Explorer 11
  • Edge
  • Chrome
  • Firefox
  • Safari

Checklist:

@Bibek-Regmi Bibek-Regmi changed the title git-531-autocomplate-amp-issues git-531-autocomplete-amp-issues Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant