Mct/bing v7 #144
Merged
Mct/bing v7 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MothOnMars
force-pushed
the
mct/bing_v7
branch
from
1df9acd
to
0a13be7
Compare
peggles2
reviewed
Sep 27, 2018
| @@ -1,4 +1,4 @@ | |||
| class AzureFormattedQuery < FormattedQuery | |||
| class BingFormattedQuery < FormattedQuery | |||
| DEFAULT_DOMAIN_SCOPE = 'site:gov OR site:mil'.freeze | |||
There was a problem hiding this comment.
Is this replacing AzureFormattedQuery? I still see it in coverage/index.html line 43909.
There was a problem hiding this comment.
Sounds like that's from a previous test run. If you nuke your coverage directory and re-run the specs, you should not see those old lines in coverage/index.html. (Searching with git grep should also ignore the coverage directory, as it's listed in .gitignore.)
peggles2
reviewed
Sep 27, 2018
| @@ -1,4 +1,4 @@ | |||
| class BingV6ImageResponseParser < BingV6ResponseParser | |||
| class BingImageResponseParser < BingResponseParser | |||
| def results | |||
There was a problem hiding this comment.
BingV6ImageResponseParser is also being referenced in : coverage/index.html line 43958 and 44265
peggles2
reviewed
Sep 27, 2018
| @@ -1,4 +1,4 @@ | |||
| class BingV5ResponseParser | |||
| class BingResponseParser | |||
| attr_reader :engine | |||
There was a problem hiding this comment.
This is also being referenced in index.html
MothOnMars
force-pushed
the
mct/bing_v7
branch
2 times, most recently
from
291656c
to
ebe6d04
Compare
MothOnMars
force-pushed
the
mct/bing_v7
branch
from
ebe6d04
to
1024fa5
Compare
MothOnMars
force-pushed
the
mct/bing_v7
branch
2 times, most recently
from
f9bc295
to
eebb6ce
Compare
MothOnMars
force-pushed
the
mct/bing_v7
branch
from
eebb6ce
to
b628620
Compare
MothOnMars
force-pushed
the
mct/bing_v7
branch
from
b628620
to
a202239
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.