Feature/bulk reindex urls #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peggles2 , I thought you were going to make all the re-index changes on one branch? This PR duplicates the db/structure.sql changes made in #172, but lacks the specs for the column addition. I think it would be best to wait for #172 to be merged to master, and then open a PR with only the additive changes so that we don't have two PRs open with the same db change. |
|
Adding a Do Not Merge label to this, as it's dependent on the migration in #172 |
MothOnMars
reviewed
Nov 15, 2018
MothOnMars
reviewed
Nov 17, 2018
MothOnMars
reviewed
Nov 17, 2018
|
@peggles2 , there are some conflicts in the VCR cassettes. I recommend checking out those cassettes from master, and then re-recording them to update them: |
MothOnMars
reviewed
Nov 19, 2018
MothOnMars
reviewed
Nov 19, 2018
MothOnMars
reviewed
Nov 19, 2018
peggles2
force-pushed
the
feature/bulk_reindex_urls
branch
2 times, most recently
from
fbd20e2
to
4ecf352
Compare
added 2 commits
November 21, 2018 16:45
MothOnMars
reviewed
Nov 21, 2018
MothOnMars
reviewed
Nov 21, 2018
|
Almost there - just a few stylistic & indendation changes to make |
…e_affiliate_has_the_jobs_govbox_enabled.yml
* SRCH-179 - Add a boolean column to the searchgov_urls * update structure.sql * migration file for enqueued for reindex to searachgov_url * update migration, update test cases * typo * remove extra space * migrated database
remove parenthesis in rspec test
MothOnMars
reviewed
Nov 27, 2018
MothOnMars
reviewed
Nov 27, 2018
peggles2
force-pushed
the
feature/bulk_reindex_urls
branch
from
8f531c8
to
4170e37
Compare
added 3 commits
December 4, 2018 11:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SRCH-183 - Update the SearchgovUrl#fetch method to set that boolean to false
SRCH-181 - Update the SearchgovURL.fetch_required scope to look for records where that boolean is true