Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRCH-2057 remove Super Admin controls for legacy SERP features #731

Merged
merged 3 commits into from
Jun 3, 2021
Merged

SRCH-2057 remove Super Admin controls for legacy SERP features #731

merged 3 commits into from
Jun 3, 2021

Conversation

MothOnMars
Copy link
Contributor

  • add Rubocop configs for ActiveScaffold controllers
  • resolve some Rubocop offenses

@MothOnMars
SRCH-2057 remove Super Admin controls for legacy SERP features
63e7dfc 
- add Rubocop configs for ActiveScaffold controllers
- resolve some Rubocop offenses
@MothOnMars MothOnMars marked this pull request as ready for review May 24, 2021 18:01
jmax-fearless
jmax-fearless approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@jmax-fearless jmax-fearless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MothOnMars MothOnMars merged commit 0a297ef into GSA:master Jun 3, 2021
@MothOnMars MothOnMars deleted the super_2057 branch June 3, 2021 19:13
@MyNameIsMissing MyNameIsMissing mentioned this pull request Jun 7, 2021
Merged
MyNameIsMissing added a commit that referenced this pull request Jun 7, 2021
@MyNameIsMissing
Release 5.0.0
56e98ae 
Functional
SRCH-2057 remove Super Admin controls for legacy SERP features (#731)

Testing only
SRCH-2308 add specs for NewsSearchHelper#current_time_filter_descript…
SRCH-2299 add integration test for agency job search (#734)
MothOnMars added a commit to MothOnMars/search-gov that referenced this pull request Aug 2, 2021
@MothOnMars
SRCH-2057 remove Super Admin controls for legacy SERP features (GSA#731)
95ff134 
- add Rubocop configs for ActiveScaffold controllers
- resolve some Rubocop offenses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmax-fearless jmax-fearless jmax-fearless approved these changes

Assignees

@jmax-fearless jmax-fearless

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MothOnMars @jmax-fearless