New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: GNOME 43 #1444
WIP: GNOME 43 #1444
Conversation
fb27c4d
to
34cb005
Compare
Added a link to the issue, just so it shows up there if someone wants to help out :) |
Just an FYI, I'm a bit stump on how to upgrade so anyone else that wants to propose/try another solution feel free to go ahead. |
How about something like this? // Since GNOME 43: aggregateMenu -> quickSettings
if (Main.panel.statusArea.quickSettings)
const AggregateMenu = Main.panel.statusArea.quickSettings;
else
const AggregateMenu = Main.panel.statusArea.aggregateMenu; |
For anyone looking to contribute to this PR, note that you will probably want to do more that just swap We have a short tutorial on how to use this API on gjs.guide with examples. It may not end up being exactly compatible with GSConnect's eccentric GMenu implementation though. |
I don't think quality of my code is good enough for a PR so I'm not creating one. Here's my commit if you want to use it while official support comes: MacTavishAO@5b381ff |
Way better than what little I have been able to do. Can't currently work on this further. |
@MacTavishAO Apparently your code quality is good enough according to @fabianhjr. Please create a new PR. |
I'm reworking on it. I will in couple of hours. |
Great! |
PR is up. #1475 |
This sort of works
closes #1428