Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: GNOME 43 #1444

Closed
wants to merge 1 commit into from
Closed

WIP: GNOME 43 #1444

wants to merge 1 commit into from

Conversation

fabianhjr
Copy link
Contributor

@fabianhjr fabianhjr commented Aug 25, 2022

This sort of works

closes #1428

@fabianhjr fabianhjr force-pushed the gnome-43 branch 2 times, most recently from fb27c4d to 34cb005 Compare August 25, 2022 16:43
@andyholmes
Copy link
Collaborator

Added a link to the issue, just so it shows up there if someone wants to help out :)

@fabianhjr
Copy link
Contributor Author

Just an FYI, I'm a bit stump on how to upgrade so anyone else that wants to propose/try another solution feel free to go ahead.

@jbicha
Copy link
Contributor

jbicha commented Sep 1, 2022

How about something like this?

// Since GNOME 43: aggregateMenu -> quickSettings
if (Main.panel.statusArea.quickSettings)
    const AggregateMenu = Main.panel.statusArea.quickSettings;
else
    const AggregateMenu = Main.panel.statusArea.aggregateMenu;

@andyholmes
Copy link
Collaborator

For anyone looking to contribute to this PR, note that you will probably want to do more that just swap aggregateMenu with quickSettings, since this is a new API.

We have a short tutorial on how to use this API on gjs.guide with examples. It may not end up being exactly compatible with GSConnect's eccentric GMenu implementation though.

@andyholmes andyholmes added the help wanted An issue that needs contributors label Sep 19, 2022
@MacTavishAO
Copy link
Contributor

MacTavishAO commented Sep 30, 2022

I don't think quality of my code is good enough for a PR so I'm not creating one. Here's my commit if you want to use it while official support comes: MacTavishAO@5b381ff

@fabianhjr fabianhjr closed this Sep 30, 2022
@fabianhjr
Copy link
Contributor Author

Way better than what little I have been able to do. Can't currently work on this further.

@yochananmarqos
Copy link

@MacTavishAO Apparently your code quality is good enough according to @fabianhjr. Please create a new PR.

@MacTavishAO
Copy link
Contributor

@MacTavishAO Apparently your code quality is good enough according to @fabianhjr. Please create a new PR.

I'm reworking on it. I will in couple of hours.

@daniellandau
Copy link
Member

Great!

@fabianhjr fabianhjr deleted the gnome-43 branch October 1, 2022 19:01
@MacTavishAO
Copy link
Contributor

PR is up. #1475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted An issue that needs contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supporting the new quick settings menu/extension
6 participants