Run Command Plugin: use systemctl for "Restart" and "Power Off" commands. #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested running the "Log Out" command multiple times from my phone, and after a few runs every extension in my computer is disabled. It seems GNOME Shell is interpreting these logouts as an unintentional defect. In that case, should we keep the "Log Out" command? |
andyholmes
force-pushed
the
command-presets
branch
from
42ec7f2
to
abf7d83
Compare
Hmm, not sure. Maybe keep it for now, let folks open bugs to see if its just a "you" issue? |
|
Sounds good :) |
Since the flag --force seems to be ignored by gnome-session-quit, it is better to use systemd for the "Restart" and "Power Off" commands. Unilike gnome-session-quit, these new commands do not show a confirmation dialog when ran.
andyholmes
force-pushed
the
command-presets
branch
from
abf7d83
to
54d1e77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to my previous PR, #1557.
Before this PR, the "Power Off", "Reboot", and "Log Out" commands displayed a confirmation dialog when ran. While this is a much welcome safety net when using the computer normally, it becomes annoying when running the commands remotely from a phone (requiring the user to go into Remote Input to click and confirm the operation).
Since we discussed it was okay to rely on systemd, I rewrote the commands for "Restart" and "Power Off" using
systemctl.