Explicitly place our menu below the network menu #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(you can also see my extension in the screenshot) |
On systems where an extension has placed itself at a higher position than the network menu (for example using an extension that adds more controls to the volume slider) the AggregateMenu index of '4' would not be where you expect it. This change makes it so that we figure out exactly where the network menu index is and place ourselves right below it.
|
Forgot to lint :') |
andyholmes
reviewed
Sep 20, 2020
|
Thanks! Just that one note and LGTM. |
In cases where there isn't a network menu in the system tray indexOf would return -1. Work around that by explicitly checking that the return is greater than -1, otherwise defaulting to 3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On systems where an extension has placed itself at a higher position
than the network menu (for example using an extension that adds more
controls to the volume slider) the AggregateMenu index of '4' would not
be where you expect it.
This change makes it so that we figure out exactly where the network
menu index is and place ourselves right below it.