4 file structure #11
Merged
4 file structure #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Mu7ammadAbed
commented
Jun 17, 2020
•
Mu7ammadAbed
commented
- I created files as required at issue File structure #4.
- I installed react server.
- I installed necessary modules for both of the server and client.
- I initialized eslint for both of server and react "client"
- I setupped eslint rules.
- I setupped vscode rules for team.
- I setupped travis.yml configurations
Mu7ammadAbed
requested review from
AlaaSaadeddin,
mariamisa,
LinaYahya and
ranasobeid95
mariamisa
previously approved these changes
Jun 17, 2020
AlaaSaadeddin
previously approved these changes
Jun 17, 2020
Mu7ammadAbed
dismissed stale reviews from AlaaSaadeddin and mariamisa
via
2efa847
| { | ||
| "name": "client", | ||
| "version": "0.1.0", | ||
| "private": true, |
There was a problem hiding this comment.
Suggested change
| "private": true, | |
| "private": true, | |
| "proxy": "http://localhost:5000", |
AlaaSaadeddin
previously approved these changes
Jun 17, 2020
LinaYahya
previously approved these changes
Jun 17, 2020
Mu7ammadAbed
dismissed stale reviews from mariamisa, LinaYahya, and AlaaSaadeddin
via
5910f60
ranasobeid95
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.