Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker compose #41

Merged
merged 7 commits into from
Jan 26, 2022
Merged

Docker compose #41

merged 7 commits into from
Jan 26, 2022

Conversation

nosnickid
Copy link
Contributor

A docker-compose setup that's mainly useful for the frontend guys atm.

The services are an equivalent of the run_plone.sh container, and a node container that runs the volto razzle dev server.

Probably wants tweaking so the plone container is built from the work @cjfairchild is doing

- reproduces run_plone.sh and `yarn install / yarn start` setup
- it drives URLs volto tries to use, not the bound adapter
- editing News Item was throwing "block is not a BlockNode"
- multiple installed versions of draft-js meant one copy of it
  parsed some data into its own BlockNode, and a separate copy
  trying to display a BlockNode didn't recognize the prototype chain
- using 'resolutions' forces a single version to be installed
  and so the parsing and display use the same module
- node 12 wasn't lts and is out of maintenance after Apr 2022
- volto 13 doesn't like node 16, the current LTS
- 14 will be fine until Apr 2023
@nosnickid nosnickid force-pushed the docker-compose branch 2 times, most recently from aeeb8bb to 9731a6c Compare January 24, 2022 11:33
@rossbowen
Copy link
Contributor

Working for me. Initially had some trouble with user: node not wanting to install things but I think that was to do with some of my Mac docker desktop settings. An update and a reset sorts the problem.

The plone container spews a lot of warnings in the terminal which appears to do with this issue, though it works as expected afterward.

Will take a look at whether we can get this working with the plone-5/instance/custom.cfg.

@nosnickid nosnickid merged commit f5cbaa9 into main Jan 26, 2022
@nosnickid nosnickid deleted the docker-compose branch January 26, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants