consistency with current codebase

GSharker · Feb 8, 2023 · 69130e9 · 69130e9
1 parent e479d42
commit 69130e9
Showing 1 changed file with 12 additions and 15 deletions.
diff --git a/src/GShark.Test.XUnit/Geometry/Vector3Tests.cs b/src/GShark.Test.XUnit/Geometry/Vector3Tests.cs
@@ -237,25 +237,22 @@ public void It_Returns_True_If_Vectors_Are_Equal()
             (vec1 == vec2).Should().BeTrue();
         }
 
-        [Fact]
-        public void It_Returns_Result_Of_Triple_Product()
+
+        [Theory]
+        [InlineData(new double[] { 1, 2, 3 }, new double[] { 4, 5, 6 }, new double[] { 7, 8, 9 }, 0)]
+        [InlineData(new double[] { 2, 3, -4 }, new double[] { 5, 1, 6 }, new double[] { -7, 8, 9 }, -527)]
+        public void It_Returns_Result_Of_Triple_Product(double[] v1, double[] v2, double[] v3, double expected)
         {
             // Arrange
-            Vector3 v1 = new Vector3(1, 2, 3);
-            Vector3 v2 = new Vector3(4, 5, 6);
-            Vector3 v3 = new Vector3(7, 8, 9);
-            // Act
-            double result = v1.TripleProduct(v2, v3);
-            // Assert
-            result.Should().Be(0);
-            // Arrange
-            Vector3 u1 = new Vector3(2, 3, -4);
-            Vector3 u2 = new Vector3(5, 1, 6);
-            Vector3 u3 = new Vector3(-7, 8, 9);
+            Vector3 testVector1 = new Vector3(v1[0], v1[1], v1[2]);
+            Vector3 testVector2 = new Vector3(v2[0], v2[1], v2[2]);
+            Vector3 testVector3 = new Vector3(v3[0], v3[1], v3[2]);
+
             // Act
-            double result2 = u1.TripleProduct(u2, u3);
+            double result = testVector1.TripleProduct(testVector2, testVector3);
+
             // Assert
-            result2.Should().Be(-527);
+            result.Should().Be(expected);
         }
 
         [Fact]