Removed Curve and Surface into ExtendedMethods.
#338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonomirco
added
the
refactor 🧰
cesarecaoduro
approved these changes
Sep 7, 2021
d3ssy
reviewed
Sep 7, 2021
src/GShark/Core/CurveHelpers.cs
Outdated
| /// <summary> | ||
| /// The curves are brought to a common degree and knots. | ||
| /// </summary> | ||
| internal static IList<NurbsCurve> HomogenizedCurves(IList<NurbsCurve> copyCurves) |
There was a problem hiding this comment.
- HomogenizeCurves()
- why "copyCurves"?
There was a problem hiding this comment.
Would it not be useful to have this split into NormaliseDegree(curves) and NormaliseKnots(curves)?
d3ssy
reviewed
Sep 7, 2021
src/GShark/Core/CurveHelpers.cs
Outdated
| { | ||
|
|
||
| /// <summary> | ||
| /// The curves are brought to a common degree and knots. |
There was a problem hiding this comment.
- Elevates degree of all curves to highest degree among all curves.
- Normalises knot vectors of all curves to the same domain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR removed the
CurveandSurfaceclasses intoExtendedMethods.Related Tickets & Documents
This PR closes #329
This PR closes #330
Added tests?
Added to documentation?