Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circle inheritance NurbsBase #360

Merged
merged 2 commits into from Sep 11, 2021
Merged

Circle inheritance NurbsBase #360

merged 2 commits into from Sep 11, 2021

Conversation

sonomirco
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

This PR removes ICurve and replace it in Circle with NurbsCurve.

Related Tickets & Documents

This PR closes #354

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📓 docs
  • 🙅 no documentation needed

@sonomirco sonomirco added the refactor 🧰 Pull requests that perform maintenance on the project but add no features or bug fixes. label Sep 11, 2021
@sonomirco sonomirco self-assigned this Sep 11, 2021
@sonomirco sonomirco added this to Review in progress in Curve via automation Sep 11, 2021
@sonomirco sonomirco merged commit 415a381 into develop Sep 11, 2021
Curve automation moved this from Review in progress to Done Sep 11, 2021
@sonomirco sonomirco deleted the dev/mibi/circle-inheritance-nurbsbase branch October 6, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sonomirco sonomirco

Labels
refactor 🧰 Pull requests that perform maintenance on the project but add no features or bug fixes.
Projects
Curve
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Circle inheritance NurbsBase
1 participant
@sonomirco