Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revolved Surface #368

Merged
merged 6 commits into from Sep 26, 2021
Merged

Revolved Surface #368

merged 6 commits into from Sep 26, 2021

Conversation

sonomirco
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

This PR adds the creation of RevolvedSurface.

Related Tickets & Documents

This PR closes #202

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📓 docs
  • 🙅 no documentation needed

@sonomirco sonomirco added the enhancement 📢 Issues describing an enhancement or pull requests adding an enhancement. label Sep 19, 2021
@sonomirco sonomirco self-assigned this Sep 19, 2021
@sonomirco sonomirco added this to In progress in Surface via automation Sep 19, 2021
@sonomirco sonomirco merged commit 4010fdc into develop Sep 26, 2021
Surface automation moved this from In progress to Done Sep 26, 2021
@sonomirco sonomirco deleted the dev/mibi/revolved-surface branch October 6, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipblaquiere philipblaquiere philipblaquiere left review comments

@d3ssy d3ssy Awaiting requested review from d3ssy

@cesarecaoduro cesarecaoduro Awaiting requested review from cesarecaoduro

Assignees

@sonomirco sonomirco

Labels
enhancement 📢 Issues describing an enhancement or pull requests adding an enhancement.
Projects
Surface
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CreateRevolvedSurface
3 participants
@sonomirco @philipblaquiere @d3ssy