Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated GitHub actions #390

Merged
merged 17 commits into from Dec 30, 2022
Merged

Updated GitHub actions #390

merged 17 commits into from Dec 30, 2022

Conversation

sonomirco
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

This PR updates the GitHub actions.
A new NuGet API Token has been provided; it should fix the error we got with the last deployment.

Related Tickets & Documents

There are no related tickets.

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📓 docs
  • 🙅 no documentation needed

@sonomirco sonomirco added the patch Pull requests requiring a patch version update according to semantic versioning. label Dec 29, 2022
@sonomirco sonomirco self-assigned this Dec 29, 2022
@sonomirco sonomirco added this to In progress in Core via automation Dec 29, 2022
@sonomirco
Copy link
Collaborator Author

sonomirco commented Dec 29, 2022

@d3ssy @cesarecaoduro
Some changes we could add to this PR.

  • Can we remove the diagram and the relative action? Or do you think it is useful?
  • Because we have the patch, minor, and major as labels, do we want to move from having alphas to semantic versioning? We could use the actual release drafter to generate the new version.
  • NetCore 3.1 from 2023 won't be supported anymore.

@d3ssy
Copy link
Collaborator

d3ssy commented Dec 29, 2022

  • Happy to remove diagram... i don't remember ever looking at it or making use of it.
  • Yes, would like to get rid of alpha releases, also never used.
  • Happy to get rid of NetCore 3.1 build target (i don't think we'll make anyone cry 😄 )
  • Shall we move to trunk based development instead of gitflow to simplify the whole CI/CD pipeline?

@sonomirco
Copy link
Collaborator Author

Sounds good to me.
So every branch will be merged on main, dev will be removed and we will use semantic version.

@cesarecaoduro
Copy link
Collaborator

cesarecaoduro commented Dec 29, 2022 via email

@sonomirco sonomirco marked this pull request as ready for review December 30, 2022 03:33
@sonomirco
Copy link
Collaborator Author

@d3ssy and @cesarecaoduro
Made all the changes.
Once we merge all the PRs, we can remove the development branch and start following trank-based development.
The actual checks build and test the solution every time a PR is created or updated in DotNet 3.1.x and 6.0.x.
I thought to keep 3.1.x only for the checks in the meantime, DotNet 7 will be consolidated.

I made some changes in the ReadMe file and on the events which are hooked and published on Discord.

@cesarecaoduro
Copy link
Collaborator

cesarecaoduro commented Dec 30, 2022 via email

@d3ssy d3ssy merged commit 5087e83 into develop Dec 30, 2022
Core automation moved this from In progress to Done Dec 30, 2022
@d3ssy d3ssy deleted the dev/mibi/pipeline-updates branch December 30, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Pull requests requiring a patch version update according to semantic versioning.
Projects
Core
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants