Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TorchDrug property optimization support #58

Closed
jannisborn opened this issue Apr 5, 2022 · 2 comments · Fixed by #168
Closed

TorchDrug property optimization support #58

jannisborn opened this issue Apr 5, 2022 · 2 comments · Fixed by #168
Labels
bug Something isn't working

Comments

@jannisborn
Copy link
Contributor

Currently, our TorchDrug interface does support property optimization conceptually.

However, most runs will fail due to an underlying bug in TorchDrug that raises whenever there is only invalid SMILES in a batch, see DeepGraphLearning/torchdrug#83

Once this is fixed in torchdrug and a new version is released on conda, we can enable our unittests (already written): https://github.com/gt4sd/gt4sd-core/blob/master/src/gt4sd/training_pipelines/tests/test_training_torchdrug_gcpn.py#L76

@jannisborn jannisborn added bug Something isn't working stalled Things that are on hold labels Apr 5, 2022
@jannisborn jannisborn removed the stalled Things that are on hold label Jun 10, 2022
@jannisborn
Copy link
Contributor Author

Update: Updated to 0.1.3 and enabled the tests. They work fine but the inference pipelines are now failing with:

raise ValueError(
"Expect node attribute `%s` to have shape (%d, *), but found %s"
% (key, self.num_node, value.shape)
ValueError: Expect node attribute `atom_feature` to have shape (8, *), but found torch.Size([4, 18])

which never occurs in the first but only in the second iteration. Not sure what's going wrong but it's not because the models were trained on 0.1.2. I trained a dummy model on 0.1.3 and it has the same problem when used for inference.

@jannisborn
Copy link
Contributor Author

Moving forward, current issue was fixed in DeepGraphLearning/torchdrug#117.

A new issue was arising when models generated only invalid molecules, I wrote a PR to fix, see: DeepGraphLearning/torchdrug#125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant