Handling case where all molecules are invalid in property optimization #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently (with the current code on
master
), if one runs the property optimization and the model produces only one unique molecule, we get this error:Moreover, when we have only invalid molecules, we get another error:
Conceptually, the error is basically the same as reported in #83 (which was fixed in #84). But this time, the affected part is the property optimization, not in the training.
SOLUTION:
Basically, what I'm doing in this PR is imitating the two return variables of
reinforce_forward
whenever the number of generated molecules is 0 or 1.Please have a look @KiddoZhu