Network throttle: Force ME update packets to be sent once every N ms. #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Item and fluid packets are separated to their own classes, as they are not even allowed to be mixed together in the first place. This will enforce a strict separation of the two. 2. New network worker thread for handling ME inventory updates. Instead of creating packets directly, classes should schedule packet(s) to be sent at the next 50ms boundary. The packet has a limit of 256 items to prevent killing the client, but this can be changed in the config. In fact, the packet send rate is also configurable. 3. Upon opening a terminal GUI, ME update packets are split. Only the last received packet will trigger a terminal sorting, so if the ME system is large, it may take several seconds (!) to load all the items.
|
@firenoo i merge only approved prs. Just let me know when it is ready for a review. |
|
@firenoo is this ready for a review? We have this code on Zeta since version 2.3.2 for testing. |
Pilzinsel64
reviewed
Apr 1, 2023
src/main/java/com/glodblock/github/network/SPacketMEFluidInvUpdate.java
Outdated
Show resolved
Hide resolved
Pilzinsel64
approved these changes
Apr 1, 2023
Dream-Master
approved these changes
Apr 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS REVERTS THE LAST COMMIT (#107)
Works fine on small systems.
Item and fluid packets are separated to their own classes, as they are not even allowed to be mixed together in the first place. This will enforce a strict separation of the two.
New network worker thread for handling ME inventory updates. Instead of creating packets directly, classes should schedule packet(s) to be sent at the next N ms boundary. The packet has a limit of 256 items to prevent killing the client, but this can be changed in the config. The packet send rate is also configurable. Packet rate is a bad name - it should really be packet period (every
packetRatems, packets are sent).For testing, if desync lag is bad, increase
packetRate. Other lag, increasepacketSize.