Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup #133

Merged
merged 27 commits into from Jun 18, 2023
Merged

Code cleanup #133

merged 27 commits into from Jun 18, 2023

Conversation

have-fun-was-taken
Copy link

The application of IntelliJ suggestions.

@have-fun-was-taken
gradle updateBuildScript
28d2ae5
@have-fun-was-taken
fix comments and commented-out code
fbbc3c1 
Code deletion, converting comments into javadocs, and refactoring code to not
need comments.
@have-fun-was-taken
remove redundant suppressions
5ba0703
@have-fun-was-taken
replace C-style array declaration with Java-style
c1dbba9
@have-fun-was-taken
make private field final
cf57bdb
@have-fun-was-taken
remove unnecessary semicolon
ec097bb
@have-fun-was-taken
extract a common part from an if
4da6b2b
@have-fun-was-taken
simplify boolean expression
bd0311f
@have-fun-was-taken
simplify ternary if
42f1cf4
@have-fun-was-taken
remove unused imports
11b09f6
@have-fun-was-taken
convert escaped characters for clarity
81d63bd
@have-fun-was-taken
replace while with for
4c8e533
@have-fun-was-taken
replace explicit types with diamond operators
f6fdb13
@have-fun-was-taken
replace anonymous type with lambda
19a886c
@have-fun-was-taken
enable modern Java syntax
9a09093
@have-fun-was-taken
migrate to enhanced switch
706f785
@have-fun-was-taken
migrate to pattern variables for instanceof
97ec2a7
@have-fun-was-taken
remove empty javadoc
f041dae
@have-fun-was-taken
add Nonnull annotation to overrides of Nonnull methods
26e75ac
@have-fun-was-taken
replace wailaStack with null
efd609d 
When wailaStack is not null, the flow breaks out of the loop,
so there's no need to confuse the reader with putting wailaStack
both as the result and the parameter of the call - there's no
recursion.
@have-fun-was-taken
int cannot be bigger than its max value
160f295
@have-fun-was-taken
suppress dataflow warning
65b0b71
@have-fun-was-taken
remove redundant initializer
b77116b 
The default value of int is 0.
@have-fun-was-taken
null check is covered by instanceof
2266c5b
@have-fun-was-taken
simplify some calls of addVertexWithUV
b6b772e
@have-fun-was-taken
fix typos and add TODOs
c958305
wlhlm
wlhlm requested changes Jun 18, 2023
View reviewed changes
Copy link
Member

@wlhlm wlhlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for your continued janitorial work on our codebases. 👍

src/main/java/com/glodblock/github/common/parts/PartFluidLevelEmitter.java Outdated Show resolved Hide resolved
src/main/java/com/glodblock/github/crossmod/waila/PartWailaDataProvider.java Show resolved Hide resolved
@Dream-Master Dream-Master merged commit d5b8ef6 into GTNewHorizons:master Jun 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlhlm wlhlm wlhlm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@have-fun-was-taken @wlhlm @Dream-Master