New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crafting input interface terminal supports #368
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't make a hard dep on GT5
Rather than having hardcoded support for specific tile, adding API for addons would be better. We have large molecular assembler for potential support as well. |
src/main/java/appeng/container/implementations/ContainerInterfaceTerminal.java
Outdated
Show resolved
Hide resolved
src/main/java/appeng/container/implementations/ContainerInterfaceTerminal.java
Outdated
Show resolved
Hide resolved
Warning: 2 uncommitted changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the hassle, we had a discussion on the interface terminal right before this PR came in so I wasn't sure how this would affect those plans
tested a bit and looks fine other than the noted change
} | ||
} | ||
} | ||
|
||
if (total != this.diList.size() || missing) { | ||
if (total != this.supportedInterfaces.size() || missing) { | ||
System.out.println( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug code should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Forgot to remove those. Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AE2FC will need a patch to get this to work, but that can be done after this gets merged (assuming no rush)
Thanks to good design, we don't have to worry about this
Other half in GTNewHorizons/GT5-Unofficial#2200 which needs to be merged after.
Closes GTNewHorizons/GT-New-Horizons-Modpack#14116
Closes GTNewHorizons/GT-New-Horizons-Modpack#14088