Do not trigger task check for all inventory slots #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D-Cysteine
approved these changes
Mar 15, 2023
DrParadox7
pushed a commit
to DrParadox7/BetterQuesting
that referenced
this pull request
Jul 1, 2023
jchung01
added a commit
to jchung01/BetterQuesting
that referenced
this pull request
Feb 14, 2024
Rongmario
pushed a commit
to CleanroomMC/BetterQuesting
that referenced
this pull request
Feb 17, 2024
* Faster TaskRetrieval::detect - reduce allocations (GTNewHorizons/StandardQuestingPack#18) * Only scan player inventories once per game tick instead of on every change (GTNewHorizons/StandardQuestingPack#18) * Do not trigger task check for all inventory slots (GTNewHorizons#90) * Prevent processing events from fake players (GTNewHorizons/StandardQuestingPack#10) * Reorder event conditions * Be consistent with PlayerInteractEvent checks * Simplify synchronized block to state check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes GTNewHorizons/GT-New-Horizons-Modpack#12107
Only trigger completion checks on changes to the main 36-slot inventory. Previously chargeable armors would trigger these checks on each tick they drained or were charged. This showed up in server profiling.
Before:
After (even while spamming drop to simulate potential normal inventory changes):
