Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rendering bugs #6

Merged
merged 6 commits into from Jun 18, 2023
Merged

Fix rendering bugs #6

merged 6 commits into from Jun 18, 2023

Conversation

eigenraven
Copy link
Member

  • Remove GlStateManager, it's useless in 1.7.10 where every mod calls raw opengl calls and can cause bugs due to wrongly cached state because of this
  • General cleanup of the code
  • Fix the blackhole/weird ambient occlusion bug due to a very wrong implementation of fullbright rendering (it permanently set every block's lightlevel to 15)

Split into commits for easier reviewing

Closes GTNewHorizons/GT-New-Horizons-Modpack#13102
Closes GTNewHorizons/GT-New-Horizons-Modpack#12291

@eigenraven eigenraven requested review from a team June 14, 2023 19:33
@chochem
Copy link
Member

chochem commented Jun 15, 2023

is it also possible this might fix GTNewHorizons/GT-New-Horizons-Modpack#11977 ?

@eigenraven
Copy link
Member Author

Unlikely

miozune
miozune approved these changes Jun 18, 2023
View reviewed changes
Copy link
Member

@miozune miozune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lets:

@miozune miozune requested a review from a team as a code owner June 18, 2023 08:48
@Dream-Master Dream-Master merged commit ee872de into master Jun 18, 2023
1 check passed
@Dream-Master Dream-Master deleted the fix-rendering-bugs branch June 18, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miozune miozune miozune approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@eigenraven @chochem @miozune @Dream-Master