Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ring of loki improvement #25

Merged
merged 4 commits into from Apr 24, 2023
Merged

Ring of loki improvement #25

merged 4 commits into from Apr 24, 2023

Conversation

LewisSaber
Copy link
Member

Item and block interactions in minecraft have 2 sides, item side and block side, before ring of loki was only able to trigger action of item, now it will first try to trigger block activation, this can be useful when you want to configure a lot of ae2 components, or want to connect a lot of wires/pipes

@Dream-Master Dream-Master requested review from a team April 24, 2023 15:56
Copy link
Collaborator

@combusterf combusterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can fix the indentation/spacing on lines 147, 152 and 160 you're good to go.

@LewisSaber
Copy link
Member Author

@combusterf Like this?

@Dream-Master Dream-Master merged commit 876b183 into master Apr 24, 2023
1 check passed
@Dream-Master Dream-Master deleted the Ring-of-loki-improvement branch April 24, 2023 18:24
DrParadox7 pushed a commit to DrParadox7/Botania that referenced this pull request Dec 4, 2023
* fix deps

* make ring trigger block activation

* remove runtime dep

* AdReSs ReVieW
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants