New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a maintenance foci, thaumic alternative to carrying a toolbox/duct-tape #60

Merged

Dream-Master merged 5 commits into GTNewHorizons:master from Cardinalstars:master

May 6, 2023

Cardinalstars commented May 5, 2023

Basic implementation of maintenance focus. It should be much cleaner than my last pr :)


          Added maintenance focus.

8efb42f

Alastors reviewed

View reviewed changes

src/main/resources/assets/emt/lang/en_US.lang Outdated Show resolved Hide resolved

Alastors reviewed

View reviewed changes

src/main/resources/assets/emt/lang/en_US.lang Outdated Show resolved Hide resolved


          Changing some lang to alastor's liking.

cf4beff

firenoo reviewed

View reviewed changes

src/main/resources/assets/emt/lang/en_US.lang Outdated Show resolved Hide resolved

Alastors reviewed

View reviewed changes

src/main/resources/assets/emt/lang/en_US.lang Outdated Show resolved Hide resolved

Alastors reviewed

View reviewed changes

src/main/java/emt/util/EMTResearchAspects.java Show resolved Hide resolved

Alastors reviewed

View reviewed changes

src/main/java/emt/util/EMTCraftingAspects.java Outdated Show resolved Hide resolved

Alastors reviewed

View reviewed changes

src/main/java/emt/util/EMTCraftingAspects.java Outdated Show resolved Hide resolved

Alastors reviewed

View reviewed changes

src/main/java/emt/init/EMTResearches.java Show resolved Hide resolved

Alastors reviewed

View reviewed changes

src/main/java/emt/init/EMTRecipes.java Outdated Show resolved Hide resolved

Alastors reviewed

View reviewed changes

src/main/java/emt/item/focus/ItemMaintenanceFocus.java Show resolved Hide resolved

Alastors requested review from a team, Dream-Master and GTNH-Colen

May 5, 2023 23:42

Alastors changed the title ~~Added maintenance focus.~~ Adding a Maintenance foci, Thaumic Alternative to carrying a toolbox/duct-tape

Alastors changed the title ~~Adding a Maintenance foci, Thaumic Alternative to carrying a toolbox/duct-tape~~ Adding a maintenance foci, thaumic alternative to carrying a toolbox/duct-tape

Member

Alastors commented May 5, 2023

Overall, it looks fine from the thaumic side of things (after some needed changes here and there in my opinion) but it needs to be reviewed from someone more focused toward GT itself before any approval can be made.


          Some tweaks and spotless apply.

d3ac5b7

miozune reviewed

View reviewed changes

src/main/java/emt/item/focus/ItemMaintenanceFocus.java Outdated Show resolved Hide resolved

src/main/java/emt/item/focus/ItemMaintenanceFocus.java Outdated Show resolved Hide resolved


          Some tweaks and spotless apply.

7200b13

miozune reviewed

View reviewed changes

src/main/java/emt/item/focus/ItemMaintenanceFocus.java Outdated Show resolved Hide resolved


          Removed as many extra calls as I could.

df272db

miozune approved these changes

View reviewed changes

Dream-Master merged commit c5a72c0 into GTNewHorizons:master

1 check failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

firenoo firenoo left review comments

Alastors Alastors left review comments

miozune miozune approved these changes

Dream-Master Awaiting requested review from Dream-Master

GTNH-Colen Awaiting requested review from GTNH-Colen