Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I've seen a few reports of the Ender IO staff of traveling and staff of teleportation somehow getting set to IIRC, near
Integer.MIN_VALUE
amount of stored energy. Reading through the code, the only way I could see for this to happen was ifreceiveEnergy
orextractEnergy
was called with a very negative number.If I'm right about the cause, then this PR will fix the symptoms for Ender IO, but it won't fix the underlying issue that we have code somewhere which occasionally overflows and calls
receiveEnergy
or (less likely)extractEnergy
with, I'm guessing, a value nearInteger.MIN_VALUE
, and any other mods that contain subclasses ofItemEnergyContainer
may still be affected by the issue.I don't know much about mix-ins, but we could also try putting these checks directly into
cofh.api.energy.ItemEnergyContainer
.