Minor hotfix + more cleanup for PowerConduitEndergy #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't break current saves completely (just doesn't load correctly - when loading with this fix, every coduit has its subtype as before) but I missed a overwrite for
readFromNBT
to get the subtype also in our child class. I now moved the subtype completely to super class that we don't need to store the subtype twice.Also I moved the code from
initIcons
to a protected method as suggested by @OneEyeMaker.