Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-apply stats tooltips to all IHiveFrame items #51

Merged
merged 3 commits into from Apr 28, 2023

Conversation

serenibyss
Copy link
Member

@serenibyss serenibyss commented Apr 28, 2023

Adds the Hold Shift style tooltip to all IHiveFrame items. This means that all Forestry frames, as well as any provided by addons, will be automatically applied.

Discrepancies from current tooltips:

  • Colors have been changed to be consistent, following a scheme of:
    • DARK_RED: very low stat
    • RED: below average stat
    • GOLD: average stat (usually just x1
    • GREEN: above average stat
    • AQUA: very good stat
  • A handful of minor inconsistencies in the old tooltips beyond colors are addressed
  • The tooltip stating "Hold Shift" is slightly modified to use Forestry's existing lang key
  • Very low stats (like the Lifespan stat of the Mutagenic Frame) are displayed in scientific notation now, as that is how Java formats small double/float values to String

Supersedes #37

Copy link
Member

@kuba6000 kuba6000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a way to override the tooltip (as a default method in IHiveFrame)

@serenibyss
Copy link
Member Author

Requested changes addressed

Copy link
Member

@kuba6000 kuba6000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
image
image
image
image

@Dream-Master Dream-Master merged commit 29df6ce into GTNewHorizons:master Apr 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants