Fix super tank output rate based on the pump used #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minecraft7771
approved these changes
Mar 22, 2023
NexusNull
pushed a commit
to NexusNull/GT5-Unofficial
that referenced
this pull request
Mar 26, 2023
* fix tank output speed * sa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the auto-output functionality for super/quantum tanks was ported over from impact, the output rates were chosen completely arbitrary and extremely high (might make sense in impact), specifically volume/100. Way higher than any pump the player can craft. This was not considered at the time. E.g. the super tank I outputs 40000L/s compared to the MV pump with 2560L/s.
Thank you for the players on discord that brought this to our attention.
However, there is a very clearly defined way to determine the output rate they should have: each one is crafted with a pump. It should just have the rate of this pump. This is not just logical, but also balanced as it directly corresponds to the tier of the player. That is implemented here.