Wiremillfix #1843
Merged
Wiremillfix #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eigenraven
reviewed
Apr 7, 2023
| .duration(baseDuration / 2) | ||
| .eut(eut) | ||
| .addTo(sWiremillRecipes); | ||
| if (!(GT_OreDictUnificator.get(prefix2, materials, 1L) == null)) { |
eigenraven
approved these changes
Apr 7, 2023
|
Thanks for finding it out, so it's not even related to my material change, so those null items i spotted are real issues, which means a reorganisation of the code is needed. |
|
I think universal fix would be adding check for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GTNewHorizons/GT-New-Horizons-Modpack#13149
I now have 1277 recipes in full game instead of just 132. And I dont see any with null input or output anymore.