MuTE overhaul and ACR #1883

minecraft7771 · 2023-04-14T16:36:10Z

This PR was initially made to add the Advanced Chemical Reactor MuTE, but in doing so many bugs were found so this is basically an overhaul by now.
Changelog:

When sneaking while rightclicking a casing with the Soft Mallet, the facing of it is changed to the side of the casing you're looking at
Fixed MuTE tanks not consuming loosing fluids, when a recipe should've consumed them
Fixed NBT data being overwritten on world load
Fixed machine being disabled on world load
Added ComplexController class, which adds all logic to make a machine that does different recipes in parallel
Added void protection support for MuTEs in GT_ParallelHelper
Added the Advanced Chemical Reactor, a tiered chemical reactor which can perform multiple recipes at once. How many is dependent on the structure upgrades
- Added item chaining to ACR. So if the item that a process outputs is on the whitelist of any process, it will prioritize output there
- Added seperate inventories for each process
Make the power switch button do a force structure check, if the machine isn't formed
Added WAILA data
Added scanner data
Fixed the structure randomly not forming
Added Motor, Pump, Piston, Conveyor, Robot Arm, Sensor, Emitter and Field Generator Functional Casings
Fixed MuTE input busses not accepting items from conveyors, hoppers etc.
Added fluid locking to fluid output casings
improved GUI of fluid IO casings
Added a MuTE Renderer and a possibility of rendering objects with it
When getting an item stack from a MuTE block in world, the default behavior is now to not save it's nbt to it
Added possibility to give the controller and casings a texture for each side. Will use empty texture as fallback.

…ewHorizons/GT5-Unofficial into MuTETextureWorkAndController

This reverts commit de4e7e7.

…ewHorizons/GT5-Unofficial into MuTETextureWorkAndController

* Allow output hatches to be fluid locked * Reworked hatch GUI

…ewHorizons/GT5-Unofficial into MuTETextureWorkAndController

mitchej123 · 2023-04-21T17:51:42Z

src/main/java/gregtech/api/enums/GT_Values.java

            LOCKED_INVENTORY = "gt.locked.inventory", // String
            LOCKED_INVENTORY_INDEX = "gt.locked.inventory.index", // Number
            UPGRADE_INVENTORY_SIZE = "gt.invsize.upg", // String
            UPGRADE_INVENTORY_UUID = "gt.invuuid.upg", // String
            UPGRADE_INVENTORY_NAME = "gt.invname.upg", // String
            UPGRADE_INVENTORIES_INPUT = "gt.invlist.upg.in", // NBT List
            UPGRADE_INVENTORIES_OUTPUT = "gt.invlist.upg.out", // NBT List
+            UPGRADE_TANK_CAPACITY = "gt.tankcapacity.upg", // Long
+            UPGRADE_TANK_CAPACITY_MULTIPLIER = "gt.tankcapacitymultiplier.upg", // Long


As mentioned in github; the nbt strings should be kept short (while still understandable).

mitchej123 · 2023-04-21T17:51:56Z

src/main/java/gregtech/api/enums/GT_Values.java

@@ -588,6 +600,10 @@ public static final class NBT {
        + EnumChatFormatting.BOLD
        + "Weabo";

+    public static final String Authorminecraft7771 = "Author: " + EnumChatFormatting.BLUE
+        + EnumChatFormatting.LIGHT_PURPLE
+        + "minecraft7771";


mitchej123 · 2023-04-21T17:53:20Z

src/main/java/gregtech/api/multitileentity/multiblock/base/Controller.java

@@ -717,6 +834,150 @@ public IIcon getTexture(OrePrefixes aBlock) {
        };
    }

+    protected <S> IStructureElementChain<S> addMotorCasings(int modes) {


@Glease Thoughts on performance of these? Any ideas for keeping them "cheap", or are they good enough?

Ideally we'd be able to immediately bail if it's not a motor casing at all... for example... 🤔

github-actions · 2023-04-21T18:18:22Z

Warning: 2 uncommitted changes
#1904

Co-authored-by: GitHub GTNH Actions <>

BlueWeabo and others added 30 commits April 12, 2023 21:03

rename refactor

7bb193f

complex controller start

32a2636

working? complex controller

efcca88

Minor tweaks

0e1dc7c

Added methods to get input fluids and items

7ce6441

Added logic to complex parallel mute

2339295

Removed unnecessary method

823826e

Added ACR and fixed many, many, many, many bugs

14706ff

Added void protection setting to checkRecipe

8140c2d

do not init nbt, if mteID and mteRegistry are the same

1e639a3

Improved GUI design

74e3c64

Merge branch 'MuTETextureWorkAndController' of https://github.com/GTN…

d0694f3

…ewHorizons/GT5-Unofficial into MuTETextureWorkAndController

Remove 2nd timer increase

cfc5e81

Force structure check when pressing power switch

69acd73

ACR Textures

b762b7e

Added T1 structure

dc246ad

Added perfect OC

2477736

Added WAILA

d5404f9

Fixed WAILA for complex controllers

8768593

Merge branch 'MuTETextureWorkAndController' of https://github.com/GTN…

e516474

…ewHorizons/GT5-Unofficial into MuTETextureWorkAndController

fix mutes resetting their nbt

de4e7e7

too many falses

4b8a6cc

Fix ACR GUI

942e89c

Revert "fix mutes resetting their nbt"

1be2b37

This reverts commit de4e7e7.

another try at fixing

3f4a3bf

Merge branch 'MuTETextureWorkAndController' of https://github.com/GTN…

6e10791

…ewHorizons/GT5-Unofficial into MuTETextureWorkAndController

Merge branch 'MuTETextureWorkAndController' of https://github.com/GTN…

f2a6b99

…ewHorizons/GT5-Unofficial into MuTETextureWorkAndController

fix npe

f8cc09c

is this worth it

1fc66cc

Merge branch 'MuTETextureWorkAndController' of https://github.com/GTN…

36f4a84

…ewHorizons/GT5-Unofficial into MuTETextureWorkAndController

minecraft7771 and others added 16 commits April 16, 2023 17:50

MuTE improved hatch GUI and fluid output locking (#1889)

81259ed

* Allow output hatches to be fluid locked * Reworked hatch GUI

Check target before trying to open GUI

24b25d0

Make ACR GUI easier to look at

d8bcc93

fix covers not rendering on mutes

7195bd5

fix covers not displaying above the item/fluid in/out

914ee66

new folder texture structure

3f8515a

Reduce network traffic caused by covers

768b1da

Fixed WAILA fluid locking display

c45992f

Don't save everything to the itemstack NBT

4431a07

Added possibility to save NBT of MuTE to its itemstack

61722b6

fix textures, but make sacrifices

ba7ac36

mah textures

e87542b

Removed the need for all textures to be present

7d7b25a

Added glow texture for active coke oven

b4f724d

Merge branch 'MuTETextureWorkAndController' of https://github.com/GTN…

42b4d18

…ewHorizons/GT5-Unofficial into MuTETextureWorkAndController

Removed unncesssary upgrade casing textures

656f07a

minecraft7771 marked this pull request as ready for review April 18, 2023 06:12

minecraft7771 requested review from a team and mitchej123 April 18, 2023 06:13

mitchej123 reviewed Apr 21, 2023

View reviewed changes

Merge branch 'master' into MuTETextureWorkAndController

00a7a0c

github-actions bot mentioned this pull request Apr 21, 2023

Spotless apply for branch MuTETextureWorkAndController for #1883 #1904

Merged

github-actions bot and others added 2 commits April 21, 2023 20:19

spotlessApply (#1904)

143ad4e

Co-authored-by: GitHub GTNH Actions <>

shorten nbt tags

897d636

mitchej123 approved these changes Apr 22, 2023

View reviewed changes

mitchej123 merged commit fdde96a into master Apr 22, 2023
2 checks passed

mitchej123 deleted the MuTETextureWorkAndController branch April 22, 2023 15:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MuTE overhaul and ACR #1883

MuTE overhaul and ACR #1883

minecraft7771 commented Apr 14, 2023 •

edited

mitchej123 Apr 21, 2023

mitchej123 Apr 21, 2023

mitchej123 Apr 21, 2023

mitchej123 Apr 21, 2023

github-actions bot commented Apr 21, 2023

MuTE overhaul and ACR #1883

MuTE overhaul and ACR #1883

Conversation

minecraft7771 commented Apr 14, 2023 • edited

mitchej123 Apr 21, 2023

Choose a reason for hiding this comment

mitchej123 Apr 21, 2023

Choose a reason for hiding this comment

mitchej123 Apr 21, 2023

Choose a reason for hiding this comment

mitchej123 Apr 21, 2023

Choose a reason for hiding this comment

github-actions bot commented Apr 21, 2023

minecraft7771 commented Apr 14, 2023 •

edited