Forge direction #1895
Merged
Forge direction #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leagris
approved these changes
Apr 22, 2023
mitchej123
force-pushed
the
ForgeDirection
branch
from
42c2fb2
to
050a769
Compare
mitchej123
force-pushed
the
ForgeDirection
branch
from
2c56c00
to
39ec25f
Compare
Also refactor the clusterfuck that was `getCoordinateScan` Co-authored by: Jason Mitchell <mitchej@gmail.com>
mitchej123
force-pushed
the
ForgeDirection
branch
from
39ec25f
to
3b49169
Compare
Frame boxes needed their own implementation of getTexture with int connexion mask, which is returning an error texture for the MetaTileEntity, because pipes (FrameBox **is** a pipe) do use this method to return different textures based on connexion status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's definitely right... don't worry about it.... cough.
@leagris Please take a look at any of the getTexture()/rendering changes you started on.
NOTE: Changes a bunch of public APIs; will require updating the addons, which should be up next now that this compiles.
Some MC APIs require int for directions/sides, in these cases the variables should be named
ordinalSideor something similar to indicate they should NOT be a ForgeDirection