Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 1 manual slot to Stocking Input Bus for lenses/molds #1946

Merged
merged 3 commits into from May 3, 2023
Merged

Adds 1 manual slot to Stocking Input Bus for lenses/molds #1946

merged 3 commits into from May 3, 2023

Conversation

kstvr32
Copy link
Contributor

@kstvr32 kstvr32 commented May 3, 2023

While Stocking Input Busses got auto-pull, allowing them to be used as input for some auto crafting machines, they don't really work for extruders or laser engravers.

These GT++ multi's don't allow sharing input busses. Therefore there is no way to set a mold or lens for a recipe when using a stocking input bus in auto-pull mode.

To rectify this, I added a single normal (non-automatable) slot intended to be used for lenses and extruder molds.

Capture

Copy link
Member

@miozune miozune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Override isValidSlot so that breaking the hatch will drop item in manual slot

@joshaup1999
Copy link

fyi, i have ++ mutlis working fine with autopull stocking and lenses. Havent tried with extruder shapes

@Fiyorin
Copy link
Contributor

Fiyorin commented May 3, 2023

fyi, i have ++ mutlis working fine with autopull stocking and lenses. Havent tried with extruder shapes

same, i don't get the premise laid out here
though it's still a useful feature to add

@Fiyorin
Copy link
Contributor

Fiyorin commented May 3, 2023

should it be added to regular input buses too? super buses?
would it make sense to allow us to disable input bus separation on gt++ multis?

@MarchingCube
Copy link

MarchingCube commented May 3, 2023

With enough items the lens or shape can end up outside of stocked item range and the machine will stop working. This happens rarely to other machines as well (like mixers).

So for example infinity chest like this:
obraz

Produces this in the stocking bus:
obraz

@Fiyorin
Copy link
Contributor

Fiyorin commented May 3, 2023

With enough items the lens or shape can end up outside of stocked item range and the machine will stop working. This happens rarely to other machines as well (like mixers).

pin the item
image

@MarchingCube
Copy link

With enough items the lens or shape can end up outside of stocked item range and the machine will stop working. This happens rarely to other machines as well (like mixers).

pin the item image

How does one pin the item?

@Fiyorin
Copy link
Contributor

Fiyorin commented May 3, 2023

How does one pin the item?

drag the item in the slot (from nei or the inventory)

@Fiyorin
Copy link
Contributor

Fiyorin commented May 3, 2023

never mind: you can't "pin" items like that in auto pulling mode.
it just takes whatever is in the system.
though that would be a nice feature to have

kstvr32 and others added 2 commits May 3, 2023 07:51
Co-authored-by: miozune <miozune@gmail.com>
@Dream-Master Dream-Master merged commit 848a361 into GTNewHorizons:master May 3, 2023
2 checks passed
Dream-Master pushed a commit that referenced this pull request May 3, 2023
* Adds 1 manual slot to Stocking Input Bus for lenses/molds

* Replace SlotGroup with SlotWidget

Co-authored-by: miozune <miozune@gmail.com>

* cleaned up code

---------

Co-authored-by: miozune <miozune@gmail.com>
(cherry picked from commit 848a361)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants