Exploring some various ForgeDirection fixes

[mitchej123]

• Fix mFacing NPEs

[leagris]

This is not gonna work

                te.setFrontFacing(te.getBackFacing());

With the current implementation of getBackFacing() in BaseMetaTileEntity:

    @Override
    public ForgeDirection getBackFacing() {
        return mFacing.getOpposite();
    }

And with the implementation of BaseMetaPipeEntity it is getting even worse with an infinite recursion:

    @Override
    public ForgeDirection getBackFacing() {
        return getFrontFacing().getOpposite();
    }

[eigenraven]

Why would there be infinite recursion? I've tested this and it runs correctly. Arguments are evaluated first, and then passed into the method call, so the code is executed as:

arg0 = te.getBackFacing()
 - (calculates opposite facing to the current state)
te.setFrontFacing(arg0) - just updates a member variable

I don't see where this would cause recursion.
Pipe's facing is just:

@Override
    public ForgeDirection getBackFacing() {
        return getFrontFacing().getOpposite();
    }

    @Override
    public ForgeDirection getFrontFacing() {
        return ForgeDirection.UNKNOWN;
    }

so it would return UNKNOWN, which doesn't matter because afaik machines can't be pipe tile entities.

[Dream-Master]

i not seen any issue ingame so lets pull this for the next dev version to test more