Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new mode for void protection & implement it for more multis #2024

Merged
merged 8 commits into from May 28, 2023
Merged

Add new mode for void protection & implement it for more multis #2024

merged 8 commits into from May 28, 2023

Conversation

miozune
Copy link
Member

@miozune miozune commented May 27, 2023 •
edited

Features

  • Add new void protection rules, item only / fluid only / item and fluid
  • Implement void protection logic to all the production multis, except for GT_MetaTileEntity_LargeBoiler, GT_MetaTileEntity_HeatExchanger, GT_MetaTileEntity_IntegratedOreFactory, GT_MetaTileEntity_MultiFurnace and GT_MetaTileEntity_ProcessingArray which are not trivial to handle
  • Make button’s pressed / disabled state more distinguishable

Implementations

  • Code is not backward compatible! Mode saved in existing TE will be converted to new mode though
  • Merge GUI code for GT_MetaTileEntity_MultiBlockBase and Controller into ControllerWithOptionalFeatures

Gallery

2023-05-28_01 43 25
2023-05-28_01 43 34

Inspired by GTCEu btw.

@miozune miozune requested review from a team May 27, 2023 14:11
This was referenced May 27, 2023
Merged
Merged
Merged
@miozune miozune changed the title Void protection improvements Add new mode for void protection & implement it for more multis May 27, 2023
minecraft7771
minecraft7771 approved these changes May 28, 2023
View reviewed changes
Copy link
Contributor

@minecraft7771 minecraft7771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@Dream-Master Dream-Master merged commit 9af7411 into master May 28, 2023
3 checks passed
@Dream-Master Dream-Master deleted the feature/void-protection-improvements branch May 28, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minecraft7771 minecraft7771 minecraft7771 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@miozune @minecraft7771 @Dream-Master