Rearrange Super and Quantum Tank GUI a little bit #2084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: 2 uncommitted changes |
|
yeah that looks a bit asymmetric before. Now it is better. |
|
@wlhlm btw is it possible to add some gui buttons for the super chest/quantum chest as well? or is this not necessary ? |
|
Probably. Let me check, I haven't looked at those. |
|
Those don't have a lock widget.
|
miozune
approved these changes
Jun 15, 2023
miozune
requested changes
Jun 15, 2023
There was a problem hiding this comment.
Oh now I remember why I placed widgets like this: It prevented accidentally clicking "void all" button when locking fluid. What do you think? @wlhlm @Dream-Master
|
I see, that could be a problem indeed. Is this better?
|
|
yeah that's better |
Also make some labels translatable.
wlhlm
force-pushed
the
tank-lock-widget-move
branch
from
19c064c
to
2d286ae
Compare
|
OK, I've updated the PR with the new voiding button locations |
miozune
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some complaining in Discord, this brings fluid contents and lock slot on the same line and moves the voiding buttons below the lock slot.