Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less hostile user interfaces (Buffer/Filter/Input bus) #2165

Merged
merged 39 commits into from Jul 28, 2023
Merged

Less hostile user interfaces (Buffer/Filter/Input bus) #2165

merged 39 commits into from Jul 28, 2023

Conversation

YannickMG
Copy link
Contributor

Relates to but does not complete GTNewHorizons/GT-New-Horizons-Modpack#10612.

Summary

Balance considerations

  • The Recipe Filter is upgraded to support recipes from multiblock machines

Functional changes

QoL changes

  • Visually toggleable buttons
  • Tooltips that don't lie about the purpose of buttons
  • Tooltips with detailed information on filters and other functionality
  • New buttons for existing functionality like sort mode and limit mode on the input bus
  • Made the visuals of the item filter cover match its behavior
  • Added tooltip about ability to set type filter by clicking with an itemstack

Code quality changes

  • Made some public members private/protected after making sure they weren't in use pack-wide
  • Migrated several strings from GT_Language_Manager to en_US.lang

Visual comparison

Toggle buttons

Before

tooltip-before

After

tooltip-after

Input bus buttons

input_bus

Sort stacks button

sort_stacks

Type filter

type-filter

Recipe filter

recipe-filter

Accurate description of various NBT modes

image image

Accurate description of various Redstone modes

redstone-full
redstone-level

Item filter cover update

Before

item-filter-cover-before

After

item-filter-cover-after

@YannickMG
Made Emit Energy button a CycleButtonWidget
f5bda0a
@YannickMG
Made Emit Redstone button a CycleButtonWidget
4eb2d70
@YannickMG
Made Invert Redstone button a CycleButtonWidget
c0b63ff
@YannickMG
Made Stocking Mode button a CycleButtonWidget
d0c98ef
@YannickMG
Spotless apply
19797bb
@YannickMG
Made Invert Filter button a CycleButtonWidget
adf9bff
@YannickMG
public bInvertFilter -> protected invertFilter
7ee6b7b
@YannickMG
Deduplicated filter code
4321294
@YannickMG
Made Allow NBT button a CycleButtonWidget
1a58bbf
@YannickMG
Made Ignore NBT button a CycleButtonWidget
fed2e60
@YannickMG
public bNBTAllowed -> private allowNbt
2481653
@YannickMG
public bNBTAllowed -> private ignoreNbt
062219d
@YannickMG
Grey extended tooltips
1f7fe48
@YannickMG
Don't hardcode multiline tooltips
60dd2e1
@YannickMG
Document hidden functionality
39ed425
@YannickMG
Cleaned numeric constants
d18fe96
@YannickMG
Fixed string constant declaration
1c448d3
@YannickMG
Named constants in filter
056837d
@YannickMG
Unify filter redstone behavior
31415f3
@YannickMG
Fix cover filter mode being inverted
2137555 
so that the displayed mode is the active one
@YannickMG
Less magic numbers
f05fa83
@YannickMG
Allow right clicking recipe filter
2abcb80
@YannickMG
Display only machine type in recipe filter and cycle through compatib…
a76e398 
…le machines
@YannickMG
Buffer tooltips show output voltage to clarify their role as passthro…
74603ca 
…ughs
@YannickMG
Added more info to Emit EU/Redstone buttons
23d8ab7
@YannickMG
Added Sorting mode button to buffers/filters
caef1e6
@YannickMG
Added Sorting mode button and stack limit button to input buses
d872789
@YannickMG
Don't cycle prefixes when clicking with itemstack
85c697f
@YannickMG
Fixed tooltips to work off of the inventory
7e40788
@YannickMG
Fix RecipeFilter losing filter
776afb5
@YannickMG YannickMG added enhancement Affects Balance Requires admin approval before merging labels Jul 22, 2023
@Dream-Master Dream-Master requested review from a team July 22, 2023 19:10
@Dream-Master
Copy link
Member

will put this in a pre tag so people can take a look

@Dream-Master
Copy link
Member

5.09.43.145-pre

@github-actions
Copy link
Contributor

Warning: 2 uncommitted changes
#2188

@github-actions github-actions bot mentioned this pull request Jul 27, 2023
Closed
@YannickMG YannickMG self-assigned this Jul 27, 2023
@github-actions
Copy link
Contributor

Warning: 2 uncommitted changes
#2189

@github-actions github-actions bot mentioned this pull request Jul 27, 2023
Closed
miozune
miozune approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@miozune miozune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw I'm glad you're back to development!

@YannickMG
Copy link
Contributor Author

btw I'm glad you're back to development!

Thanks, I hope it'll last a while but we'll see. :)

@Dream-Master Dream-Master merged commit 190d29e into master Jul 28, 2023
2 checks passed
@Dream-Master Dream-Master deleted the buffer-filter-ui-update branch July 28, 2023 13:03
@YannickMG YannickMG mentioned this pull request Jan 9, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miozune miozune miozune approved these changes

Assignees

@YannickMG YannickMG

Labels
Affects Balance Requires admin approval before merging enhancement
Projects
None yet
Milestone
No milestone
3 participants
@YannickMG @Dream-Master @miozune