Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up GT++ code #589

Merged
merged 43 commits into from Apr 8, 2023
Merged

clean up GT++ code #589

merged 43 commits into from Apr 8, 2023

Conversation

boubou19
Copy link
Member

@boubou19 boubou19 commented Apr 4, 2023

according to our own policy, GTPlusPlus support is GTNH only, so with Dream's approval, i yeeted the following
compats:

  • Big Reactors
  • IC2 classic
  • Pneumaticraft
  • More Planets
  • Psychedelicraft
  • Beyond Reality Core
  • Simply Jetpacks
  • RFTools
  • CompactWindmills
  • GrowthCraft
  • ThermalFoundation
  • IHL
  • Mekanism
  • Redtech
  • xReliquary

Other things i also did:

  • I removed the use of LoadedMods.java, as we now have a fancy GT5U enum for mod ids
  • i optimized imports
  • removed hazmat utility class
  • i started to put all the recipes in the same place (only some pyrolyse oven for now)

Config changes:

  • removed # Makes LuV+ Casings and Hulls more difficult to craft. [default: false] B:enableHarderRecipesForHighTierCasings=false and its usages because it's both by default off within GTPP and in the modpack config

@boubou19 boubou19 marked this pull request as draft April 4, 2023 17:52
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

Warning: 2 uncommitted changes
#590

@miozune
Copy link
Member

miozune commented Apr 5, 2023

Can you also remove HazmatUtils if it's within the scope of this PR? It was moved to GT and does nothing

@boubou19
Copy link
Member Author

boubou19 commented Apr 5, 2023

sure

@boubou19 boubou19 marked this pull request as ready for review April 8, 2023 22:52
@Dream-Master Dream-Master merged commit 873ff5e into master Apr 8, 2023
1 check passed
@Dream-Master Dream-Master deleted the cleaning_stuff branch April 8, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants