Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect ulv turbine tooltip #598

Merged
merged 2 commits into from Apr 11, 2023
Merged

fix incorrect ulv turbine tooltip #598

merged 2 commits into from Apr 11, 2023

Conversation

Glease
Copy link
Contributor

@Glease Glease commented Apr 11, 2023

@Glease Glease requested a review from a team April 11, 2023 04:05
@github-actions github-actions bot mentioned this pull request Apr 11, 2023
Merged
@github-actions
Copy link
Contributor

Warning: 2 uncommitted changes
#599

@github-actions
spotlessApply (#599)
044c301 
Co-authored-by: GitHub GTNH Actions <>
@Dream-Master Dream-Master merged commit 35be1ba into master Apr 11, 2023
1 check passed
@Dream-Master Dream-Master deleted the fix/incorrect-ulv-turbine-tooltip branch April 11, 2023 08:28
@immibis
Copy link

immibis commented Apr 12, 2023

for anyone confused why getEfficiency is not edited: the base class calculates the efficiency as (600 / efficiency)%. Not sure how the generation is calculated, but that's how the tooltip is calculated. The simple formula of efficiency% which was being overridden here was incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dream-Master Dream-Master Dream-Master approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Glease @immibis @Dream-Master